- devel - lists.freelock.com

LedgerSMB 1.5.12 released
by Erik Huelsmann 18 Sep '17

18 Sep '17

The LedgerSMB development team is happy to announce yet another new version of its open source ERP and accounting application. This release contains the following fixes and improvements: Changelog for 1.5.12 * Fix depreciation method listing incorrect stored procedure (Erik H) * Fix failure to select business type details from business list (Erik H, #3154) * Require fixed asset values needed in depreciation to be entered (Erik H) * Fix the Net Book Value report listing assets by the wrong class (Erik H) * Fix the Net Book Value report incorrectly excluding some assets (Erik H) * Fix Ship To screen reporting server error and staying blank (Erik H, #2516) * Fix non-existing entry-point error on 'Approve' in fixed assets (Erik H) * Fix errors due to double 'action' field in fixed assets reports (Erik H) * Fix disposal-specific fields appearing in depreciation screens (Erik H) * Fix Parts Group drop-down and column selector in Goods Search (Erik H, #1581) * Require proceeds on disposal prevents NULL amounts on approval (Erik H) Erik H is Erik Huelsmann For installation instructions and system requirements, see https://github.com/ledgersmb/LedgerSMB/blob/1.5.12/README.md The release can be downloaded from our download site at http://download.ledgersmb.org/f/Releases/1.5.12/ The release can be downloaded from GitHub at https://github.com/ledgersmb/LedgerSMB/releases/tag/1.5.12 Or pulled from Docker Hub using the command $ docker pull ledgersmb/ledgersmb:1.5.12 These are the sha256 checksums of the uploaded files: a73adc8ef9f4f7c6bc6546ee58b066138b11cc92f7ea6eff843da6ff7f874520 ledgersmb-1.5.12.tar.gz 45e0dada224df8d8d6ae08213d15d5597803fac6b043d3fe186127dd6a6e37c8 ledgersmb-1.5.12.tar.gz.asc

1 0

LedgerSMB 1.4.42 released (end-of-life release)
by Erik Huelsmann 16 Sep '17

16 Sep '17

The LedgerSMB development team is happy to announce yet another new version of its open source ERP and accounting application. This will be the last release in the 1.4 series, which has reached End-Of-Life (EOL) status on September 15, 2017; after three full years of active maintenance. The fact that the release series has reached EOL status means that no further community supported releases will be created - except for translation updates when available. Users are encouraged to upgrade to the 1.5 series which is now the community supported version. In case upgrades are not an option, support may be available through commercial support channels (https://ledgersmb.org/topic/commercial-support) This release contains the following fixes and improvements: Changelog for 1.4.42 * Fix goods/services search with AR/AP invoices (Chris T, #2938) * Fix ar/ap not searchable by part number (Chris T, #2926) * Round-trip fewer values over web requests during migration (Erik H) * Bank account info now properly HTML-escaped (Erik H, #2820) * Ensure forked sub-processes to be correctly terminated (Erik H) * Fix missing content in columns of the outstanding report (Erik H, #2585) * Fix contacts search ignores e-mail and phone filters (Erik H, #2821) * Fix contacts search by address data doesn't work (Erik H, #2490) Chris T is Chris Travers Erik H is Erik Huelsmann The release can be downloaded from our download site at https://download.ledgersmb.org/f/Releases/1.4.42 Or pulled from Docker Hub using the command $ docker pull ledgersmb/ledgersmb:1.4.42 Additionally, the release can also be downloaded from GitHub at https://github.com/ledgersmb/LedgerSMB/releases/tag/1.4.42 These are the sha256 checksums of the uploaded files: 64b3e70559e2e66a9b1b41b2937ac3e68ef47f8b1006f092bafde60941b8a1ba ledgersmb-1.4.42.tar.gz 9129f407bb0ab372f0e0f6388e97e3765b1cd96ca0a02fe6d9e3f9a8331b7b02 ledgersmb-1.4.42.tar.gz.asc

1 0

Release of ledgersmb-1.5 v1.5.11-1
by Robert J. Clay 15 Sep '17

15 Sep '17

An initial version of the debian package for ledgersmb-1.5 for version 1.5.11-1 has been released and uploaded to our apt package repository for 'main' in stretch. It has also been uploaded to our PPA, for 'artful' (the future v17.10). (The Debian source packages are available as well.) Note that this version of the package does not include ledgersmb-1.5-apache for the Apache proxy configuration as there is still an unresolved issue with that but does include ledgersmb-1.5-nginx for the Nginx proxy configuration. The ledgersmb-1.5-lighttpd and ledgersmb-1.5-varnish proxy configuration packages are also still in the process of being added. At our apt package repository[1]: ledgersmb-1.5_1.5.11-1_all.deb ledgersmb-1.5-nginx_1.5.11-1_all.deb At our PPA[2]: ledgersmb-1.5_1.5.11-1~ubuntu17.11.1_all.deb ledgersmb-1.5-nginx_1.5.11-1~ubuntu17.11.1_all.deb -- Robert J. Clay rjclay(a)gmail.com, jame(a)rocasa.us GPG ID: 2448 3AE0 874D 8696 6DCD ECF4 198C AB6F 43B7 EA9A [1] https://apt.ledgersmb.org/ [2] https://launchpad.net/~ledgersmb/+archive/ubuntu/main/+packages

1 1

LedgerSMB 1.5.11 released
by Erik Huelsmann 12 Sep '17

12 Sep '17

The LedgerSMB development team is happy to announce yet another new version of its open source ERP and accounting application. This release contains the following fixes and improvements: Changelog for 1.5.11 * Rename lighttpd example configuration file for consistency (Yves L) * Fix Net Book Value report shows 'LedgerSMB::Report' as its name (Erik H, #3132) * Fix Depreciation screen not showing any assets (Erik H, #3131) * Fix fixed asset's 'Usable life' field not showing entered value (Erik H, #3130) * Fix Net Book Value report's link to asset details broken (Erik H, #3129) * Ensure forked sub-processes to be correctly terminated (Erik H) * Fix Form submission sometimes seems to hang (Erik H, #2972) * Fix missing content in columns of the outstanding report (Erik H, #2585) * Fix contacts search ignores e-mail and phone filters (Erik H, #2821) * Fix contacts search by address data doesn't work (Erik H, #2490) Yves L is Yves Lavoie Erik H is Erik Huelsmann The release can be downloaded from our download site at https://download.ledgersmb.org/f/Releases/1.5.11 Or pulled from Docker Hub using the command $ docker pull ledgersmb/ledgersmb:1.5.11 For installation instructions and system requirements, see https://github.com/ledgersmb/LedgerSMB/blob/1.5.11/README.md Additionally, the release can also be downloaded from GitHub at https://github.com/ledgersmb/LedgerSMB/releases/tag/1.5.11 These are the sha256 checksums of the uploaded files: b483095512828683efdd6d85216ee069999e45b0e4ba9502943ac3f88c94d44d ledgersmb-1.5.11.tar.gz 6deba09673f0cefa222ae1b868a541a855ca270011b17f11fd0e950460b1b038 ledgersmb-1.5.11.tar.gz.asc

1 0

Release of ledgersmb-1.5 v1.5.10-1
by Robert J. Clay 04 Sep '17

04 Sep '17

All, An initial version of the debian package for legdgersmb-1.5 for version 1.5.10-1 has been released and uploaded to our apt package repository for 'main' in stretch. It has also been uploaded to our PPA, for 'artful' (the future v17.10). (The Debian source packages are available as well.) Note that this version does not include ledgersmb-1.5-apache for the Apache proxy configurtion as there is still an unresolved issue with that but does include ledgersmb-1.5-nginx for the Nginx proxy configuration. At our apt package repository: ledgersmb-1.5_1.5.10-1_all.deb ledgersmb-1.5-nginx_1.5.10-1_all.deb At our PPA: ledgersmb-1.5_1.5.10-1~ubuntu17.10.1_all.deb ledgersmb-1.5-nginx_1.5.10-1~ubuntu17.10.1_all.deb -- Robert J. Clay rjclay(a)gmail.com jame(a)rocasa.us 4096/198CAB6F43B7EA9A [1] https://apt.ledgersmb.org/ [2] https://launchpad.net/~ledgersmb/+archive/ubuntu/main/+packages

1 0

LedgerSMB 1.5.10 released
by Erik Huelsmann 03 Sep '17

03 Sep '17

The LedgerSMB development team is happy to announce yet another new version of its open source ERP and accounting application. This release contains the following fixes and improvements: Changelog for 1.5.10 * Fix loading image URL taken from Dojo 1.12 (instead of 1.10) (Erik H) * Fix mails being sent with non-unique Message-IDs (Erik H, #3041) * Round-trip fewer values over web requests during migration (Erik H) * Migrate accounting <-> invoice relationship from LSMB 1.2/SL (Erik H/Yves L) * Fix 500 ISE on bottom of order when creating from vendor (Erik H, #3057) * Contact info now properly HTML-escaped (Erik H, #2820) * Add check for cr_coa_to_account primary key to 1.3 migration (Erik H, #2663) * Add work-around to PGOld for PGObject::Simple 2.x incompatibility (Chris T) * Fix missing asset classes on Depreciate and Disposal screens (Erik H, #3123) Erik H is Erik Huelsmann Yves L is Yves Lavoie Chris T is Chris Travers The release can be downloaded from our download site at https://download.ledgersmb.org/f/Releases/1.5.10/ Additionally, the release can be downloaded from GitHub at https://github.com/ledgersmb/LedgerSMB/releases/tag/1.5.10 or pulled from Docker Hub using the command $ docker pull ledgersmb/ledgersmb:1.5.10 These are the sha256 checksums of the uploaded files: e2fcb54bcf5c93196a2b0e75c1b5d5dec72842b020c73f79c9bef636cc61da0f ledgersmb-1.5.10.tar.gz 9ba36a9c0420600cd6026f7511067626743b607c87c09164f7ab5b7255766477 ledgersmb-1.5.10.tar.gz.asc

1 0

Proposal on error handling
by Chris Travers 31 Aug '17

31 Aug '17

I was hoping to work on removing some of the difficulty this weekend but I think it would be a good to have a full discussion and hammering out of details first. As Erik pointed out in the template thread, our error handling is a mess. In some cases we are returning undef, in some cases we are throwing localised strings. The undef cases make for a few problems, but the localised strings mean we have no machine-readable error handling and is far worse. Among the problems with that: 1. If you want to, say, get the details of a GL transaction, you have to have a locale object. If you are running a program from outside the LSMB directory, that is easier said than done. 2. If something goes wrong, you cannot determine what the error was and handle it. This is a problem on both old and new code but it is a much bigger problem on old code. I think the easiest way of rectifying the situation is to recognise the code is fairly database-centric and build an error handling mechanism which largely extends the SQL State/message approach. I am going to suggest we standardise on the following: 1. We have a particular exception class (maybe an external one, maybe I write PGObject::Util::Exception). That exception class has four fields: a) an error code based on the SQL State table for current PostgreSQL b) an optional log message, and c) an optional query string d) an optional list of parameters which caused the error 2. When a database errors, we throw the sql state, query string, parameters, and a log message of class and method which caused the error. 3. Not found returns undef. If we must throw an exception we use 02000 as the SQL state. I expect that this is most common in the old code. In new code we could turn this into a 404 code if we want to. 4. Precondition checks croak with states that typically start with 22. In new code we could turn this into a 400 error code. Does this seem reasonable? -- Best Wishes, Chris Travers Efficito: Hosted Accounting and ERP. Robust and Flexible. No vendor lock-in. http://www.efficito.com/learn_more

1 0

RFC: Formalize templates interface and split out onto CPAN
by Chris Travers 31 Aug '17

31 Aug '17

Hi; I have been thinking of what else we can/should split out sometime soon to CPAN and it has occurred to me that the interface of the templates could probably be split out (and maybe the mailer too). Both of these however contain LedgerSMB-specific assumptions and would need to be rewritten to some extent to address these. However with the templates in particular, removing these assumptions would help us get rid of a lot of the CGI assumptions we are currently making. In particular, I am thinking of the automatic output options which I think should be abstracted away or even removed. A major justification for this is that reporting endpoints for my LedgerSMB API gateway are much harder to implement across a Dancer interface than they should be, because we assume we are operating in a CGI environment. I would like to do this for the following reasons: 1. I would really like to be able to use the reporting generation in areas outside of a CGI web application, and 2. It would be nice to be able to open up additional formats to third party developers saying "Put it on CPAN and tell people they can install it like so." I would like to suggest that over the next major version or two I work on refactoring out or abstracting away the LedgerSMB-specific and CGI-specific assumptions to the templating interface, provide a dynamic format registration mechanism, and the like. And then work towards breaking these off once this is complete. Are there any thoughts on this? -- Best Wishes, Chris Travers Efficito: Hosted Accounting and ERP. Robust and Flexible. No vendor lock-in. http://www.efficito.com/learn_more

3 9

Returning only content-type header from LedgerSMB::Template
by Erik Huelsmann 31 Aug '17

31 Aug '17

With the idea to simplify our LedgerSMB::Template handler, by moving all headers (but the content-type) from there to LedgerSMB::PSGI, I went to task: In the referenced issue, you write >>> >>> The template should be responsible *only* to render the content and >>> provide a file mime type back with it. This means that the output of >>> template->render() should ... >>> >>> Assuming that "template" there corresponds to my definition of >>> "LedgerSMB Template Engine" (concluded from the fragment of the second >>> sentence), I really wonder what value the template engine is providing: our >>> template processor has a render method too; the *only* thing it lacks is >>> the content type return value. The content type can be easily added based >>> on the extension of the processed template in a generic handler elsewhere >>> though. >>> >> >> Right. >> >>> >>> In the same paragraph, you continue >>> >>> The Template MUST NOT assume HTTP, PSGI, or any other particular >>> input/output format. >>> >>> Could you have a look and https://github.com/ledgersmb/L >>> edgerSMB/blob/master/lib/LedgerSMB/Template.pm#L540 ? I think that that >>> achieves what you want. >>> >> >> Yes, though more specifically, I think if we *do not use* PSGI or output >> options we achieve something much better. What I want to achieve is a >> clearer separation of responsibility and I think this has cascading >> benefits through the rest of the application as well as making the logic >> more general. >> > > Ok. You're proposing the return value being a pair: the expanded template > and the mime-type. The current implementation is a list of headers (usually > just the mime-type), the expanded template and a success/fail indicator (a > triplet). > > If we want to go with just the pair, how are we going to report the > success/fail indicator? (In other words, how do we report error > conditions?) I'll move the handling of the cache control headers currently > in "render_to_psgi()" to LedgerSMB::PSGI. That's a positive outcome of this > discussion for sure. > I have local work-in-progress. I've successfully moved the characterset addition to (utf-8) to all "text/" mime-types as well as the headers disabling caching when "back button disabling" is enabled, to LedgerSMB::PSGI. However, I'm trying to move the Content-Disposition headers to LedgerSMB::PSGI, but that's not quite so easy: the disposition header uses knowledge from the template (the type and name of the report). This information is not available on the LedgerSMB::PSGI level. So, how do I meaningfully name the downloaded file in this new world order? Regards, -- Bye, Erik. http://efficito.com -- Hosted accounting and ERP. Robust and Flexible. No vendor lock-in.

2 1

Re: [ledgersmb-devel] Setting a policy for our dependencies
by Chris Travers 30 Aug '17

30 Aug '17

As a couple notes, I would add the following expansions to this. "Allow the widest possible version range on any module, disallowing individual malfunctioning versions to further extend the range" I think we are better off documenting bugs in misbehaving versions of modules and perhaps offering a module check utility rather than disallowing certain versions of modules. I say this for two reasons: 1. Managing this list is annoying and deciding when to block a specific version of a module is going to be an annoying and political decision, and 2. A block on a module version will not prevent someone who has an older version of the module from upgrading to a blocked version since it is an install-time check and another piece of software could require a newer version and thus break the install-time check. So I would suggest deciding required versions by first-supported version and up, and providing a tool or just documentation for checking for other problems in the mean time. Secondly I would like to suggest that a focus on moving things to CPAN and breaking the application into components for better testability. "Require as few a possible modules in the expanded dependency tree (prefer modules as direct dependencies which are already depended on implicitly)" Additionally I think that when we spin things off we should shoot for modules which are simple in interface, within a year or two will likely be pretty close to bug free and unlikely to require dramatic modifications, and therefore keep spin-offs throttled so they do not cause undue chaos for packagers. " Not depend directly on modules which have overlapping functionalities" Big caveat here is that some modules that are used *because* they are overlapping might be in a different position. Moo/Moose is a good example and both are widely used enough that there is no harm in using Moo instead of Moose in spun-off modules. However we still have some old paradigms in the code that need to be cleaned up and we should also focus on this. "Not require modules which only provide nice-to-have functionality" Also, while I am happy to see optional modules used to provide nice-to-have functionality it is worth noting that there are two things that need to be guarded against here. The first are extra dependencies. The second is extra code complexity that comes with adding such options. I would say that both need to be justified before we should allow them and where we do allow them we should think about how to set up proper interfaces so we don't have lots of conditional module handling everywhere. "Group feature dependencies into their respective features as much as possible (so as to not require them for a more basic installation)" A corollary here might be that long-run a lot of the application today should be relegated to optional features as we go forward. If someone doesn't need inventory tracking, why install it? If one doesn't need more than GL, customers, vendors, and basic reporting, why install more than that? Of course we aren't there yet but I would suggest that a forward-thinking view of dependencies we might want to think about it not only regarding the dependency problems we encounter with maintaining and working on the current code but also in the question of how modularised and loosely coupled we may want the code to be in the future. Best Wishes, Chris Travers -- Best Wishes, Chris Travers Efficito: Hosted Accounting and ERP. Robust and Flexible. No vendor lock-in. http://www.efficito.com/learn_more

4 11